Skip to content

fix: Add memory & table for esm binding's exports #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MaxGraey merged 9 commits into from
Jul 20, 2022
Merged

fix: Add memory & table for esm binding's exports #2344

MaxGraey merged 9 commits into from
Jul 20, 2022

Conversation

@MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Jun 27, 2022

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO June 27, 2022 18:32
dcodeIO
dcodeIO reviewed Jun 27, 2022
View reviewed changes
@MaxGraey MaxGraey requested a review from dcodeIO June 27, 2022 18:58
dcodeIO
dcodeIO reviewed Jun 27, 2022
View reviewed changes
MaxGraey and others added 2 commits June 27, 2022 22:03
@MaxGraey @dcodeIO
Update src/bindings/tsd.ts
e974445 
Co-authored-by: dcode <dcode@dcode.io>
@MaxGraey
update
3426b65
@dcodeIO
Copy link
Member

dcodeIO commented Jun 27, 2022

Can you update the fixtures of the raw bindings? Should have memory in it now, too.

@dcodeIO
Copy link
Member

dcodeIO commented Jun 27, 2022

Also, the same seems to be true for table. Would it perhaps be good to add it here as well?

dcodeIO
dcodeIO reviewed Jun 27, 2022
View reviewed changes
@MaxGraey MaxGraey changed the title fix: Add memory for esm binding's exports fix: Add memory & table for esm binding's exports Jun 27, 2022
@MaxGraey MaxGraey requested a review from dcodeIO June 27, 2022 19:20
@dcodeIO
Copy link
Member

dcodeIO commented Jun 27, 2022

Would expect to see a diff in bindings/raw.[debug|release].d.ts due to the added memory definition. Is that somehow not showing up?

@MaxGraey MaxGraey merged commit 2d18059 into AssemblyScript:main Jul 20, 2022
@MaxGraey MaxGraey deleted the fix-memory-export-for-binding-esm branch July 20, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees

No one assigned

Labels

enhancement tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxGraey @dcodeIO