Skip to content

[cli] Prevent uses binaryFile in options #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxGraey merged 1 commit into from
Aug 15, 2022
Merged

[cli] Prevent uses binaryFile in options #2380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cli/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,6 +855,10 @@ export async function main(argv, options) {

// Prepare output
if (!opts.noEmit) {
if (opts.binaryFile) {
// We catched lagacy field for binary output (before 0.20)
return prepareResult(Error("`binaryFile` doesn't support. Please use `outFile` instead."));
Copy link
Member

@dcodeIO dcodeIO Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps

Usage of the --binaryFile compiler option is no longer supported. Use --outFile instead.

}
let bindings = opts.bindings || [];
let hasStdout = false;
let hasOutFile = opts.outFile != null;
Expand Down