Update binaryen #2547
Closed
Update binaryen #2547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MaxGraey
commented
Nov 2, 2022
MaxGraey
commented
- I've read the contributing guidelines
- I've added my name and email to the NOTICE file
dcodeIO
reviewed
Nov 18, 2022
Co-authored-by: dcode <dcode@dcode.io>
dcodeIO
reviewed
Nov 18, 2022
| (data (i32.const 1036) "\1c") | ||
| (data (i32.const 1048) "\02\00\00\00\02\00\00\00a") | ||
| (table $0 1 1 funcref) | ||
| (elem $0 (i32.const 1)) |
Member
There was a problem hiding this comment.
Any idea what's going on here? Seems strange that this affects just a few release tests.
Member
Author
There was a problem hiding this comment.
No idea. Perhaps a some regression in Binaryen?
Member
Author
There was a problem hiding this comment.
debug fixture contains this:
Member
Author
There was a problem hiding this comment.
I tried to remove new "reorder-globals" pass, but this didn't help
Member
|
Would it be good to make the pass pipeline change still? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.