Open
Conversation
TODO: ControlBox does not work correctly
wolframhaussig
force-pushed
the
feature/16-feature-form-styling-does-not-work-for-mdi-children
branch
from
651da09 to
718270f
Compare
…aw the ControlBox
…the width becomes too small
…rm-styling-does-not-work-for-mdi-children # Conflicts: # StylableWinFormsControls/StylableWinFormsControls/StylableWinFormsControls.csproj
Nockiro
requested changes
Nov 2, 2023
Contributor
There was a problem hiding this comment.
In general: Looks good, only:
- we need to extend the docs
- not to be that guy, but several analyzer warnings have been introduced with this
I could take care of both if you'd like?
Edit:
On my second look in the example form: Shouldn't MDI child forms be movable as far as I remember? I've not much experience with them to be honest, but at least the resize cursor that appears on the edges should either a) not be there or b) do something 😄
| switch (style) | ||
| { | ||
| case FormBorderStyle.Fixed3D: | ||
| //TODO: Implement |
Contributor
There was a problem hiding this comment.
Is this TODO intended to be included in this PR?
Contributor
Author
There was a problem hiding this comment.
Maybe not. I wanted to start providing support for MDI but as I currently have no usecase myself it is not high priority.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16