First proposal for editing DateTimePicker values#29
Draft
wolframhaussig wants to merge 6 commits intomainfrom
Draft
First proposal for editing DateTimePicker values#29wolframhaussig wants to merge 6 commits intomainfrom
wolframhaussig wants to merge 6 commits intomainfrom
Conversation
wolframhaussig
force-pushed
the
bug/24-bug-keyboard-control-behavior-of-the-stylabledatetimepicker-control
branch
from
5d92f77 to
258bb62
Compare
wolframhaussig
force-pushed
the
bug/24-bug-keyboard-control-behavior-of-the-stylabledatetimepicker-control
branch
from
af2c50e to
1753730
Compare
…not full day of week or month names)
Nockiro
reviewed
Aug 11, 2023
Contributor
Nockiro
left a comment
Nockiro
left a comment
There was a problem hiding this comment.
I like the current approach, I do however see a bit of space for improvements:
- if we support keyboard input , we should support it in all aspects (-> WoD and month, too) to avoid confusion, imo
- the current spacing works fine for
Format=Long, but not so well forFormat=Shortor evenFormat=Time. We should probable use different spacing values for each of them.
…ontrol-behavior-of-the-stylabledatetimepicker-control # Conflicts: # StylableWinFormsControls/StylableWinFormsControls/Controls/StylableDateTimePicker.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #24
TODO: