Merged
Conversation
Contributor
Author
|
Functionally correct but doesn't account for PoV issue. If attempting to reproduce locally, please keep in mind that there's a bug in |
5a89aad to
bf1fe3d
Compare
2 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Context
pallet-contractsv9 storage migration can blow up in PoV size and this happened with Shibuya.This PR provides an approach to migrate the storage in multiple steps.
pallet-contractsand doing the modification directly in therepallet-contractsare only available topallet-contractscrate so they had to be redefined hereNOTE
It seems that PoV size is overestimated in the code (double the size we got with Shibuya upgrade).
As long as it's not underestimated it should be fine.
Check list