Conversation
I know, we want to get rid of z_order eventually. But that's for later. Now, in the context of the effects dataclasses change, and the changes to meta associated with that, I need to make this move anyway. I realized this can be done independently, so why not. Also, conceptually, the z_order is a property of the class, not the instance. As in, any instance of an effect class will not change the z_order. That is, except AtmosphericDispersionCorrection apparently, but that should work as well.
Again, these are about the whole class, rather than individual instances.
teutoburg
added
refactor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 76.93% 73.98% -2.96%
==========================================
Files 66 66
Lines 8139 8210 +71
==========================================
- Hits 6262 6074 -188
- Misses 1877 2136 +259 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Network tests fail with timeout, also after retry, I'll try again in an hour or so, but this is unrelated to the PR... Codecov complains because I guess more covered lines were removed or something... |
oczoske
approved these changes
Nov 13, 2024
Collaborator
oczoske
left a comment
oczoske
left a comment
There was a problem hiding this comment.
Defining z_order as a class variable makes a lot of sense. Looks good to me.
hugobuddel
approved these changes
Nov 13, 2024
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #489. Decided to make the z_order (and some afaik not-really-used) report stuff class attributes, because both are conceptually properties of the class, not the instance. This will also come in handy in the upcoming (at some point) effects -> dataclass change, because there's no point in having
z_orderas part of an effect's constructor.Also, no. 500 🥳 🎉 🚀