Skip to content

Fix TypeError when MCP schema type is a list #4867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Soulter merged 3 commits into from
Feb 5, 2026
Merged

Fix TypeError when MCP schema type is a list #4867

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
857290b
Fix TypeError when MCP schema type is a list
boushi1111 Feb 4, 2026
a7bd954
Refactor: avoid modifying schema in place per feedback
boushi1111 Feb 4, 2026
dfe072c
Fix formatting and cleanup comments
boushi1111 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions astrbot/core/agent/tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,18 @@ def convert_schema(schema: dict) -> dict:

result = {}

if "type" in schema and schema["type"] in supported_types:
result["type"] = schema["type"]
# Avoid side effects by not modifying the original schema
origin_type = schema.get("type")
target_type = origin_type

# Compatibility fix: Gemini API expects 'type' to be a string (enum),
# but standard JSON Schema (MCP) allows lists (e.g. ["string", "null"]).
# We fallback to the first non-null type.
if isinstance(origin_type, list):
target_type = next((t for t in origin_type if t != "null"), "string")

if target_type in supported_types:
result["type"] = target_type
if "format" in schema and schema["format"] in supported_formats.get(
result["type"],
set(),
Expand Down