fix(dashboard): show full command description#7815
fix(dashboard): show full command description#7815bugkeep wants to merge 2 commits intoAstrBotDevs:masterfrom
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider omitting the
titleattribute whenitem.descriptionis falsy (instead of showing'-'in the tooltip) so users don’t get a confusing tooltip that doesn’t add information beyond the placeholder text.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider omitting the `title` attribute when `item.description` is falsy (instead of showing `'-'` in the tooltip) so users don’t get a confusing tooltip that doesn’t add information beyond the placeholder text.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request adds a hover title to the description column in the CommandTable component to display the full text when it is truncated. The review feedback suggests replacing the native title attribute with Vuetify's v-tooltip for consistency with the rest of the application and recommends only showing the tooltip when a description is present to avoid displaying a redundant dash on hover.
| <div | ||
| class="text-body-2 text-medium-emphasis" | ||
| :title="item.description || '-'" | ||
| style="max-width: 280px; overflow: hidden; text-overflow: ellipsis; white-space: nowrap;" | ||
| > | ||
| {{ item.description || '-' }} | ||
| </div> |
There was a problem hiding this comment.
Using a native title attribute is inconsistent with the rest of the application, which utilizes Vuetify's v-tooltip component (e.g., in the actions column). v-tooltip provides a more polished user experience and consistent styling. Additionally, the tooltip should only be displayed when a description is present to avoid showing a redundant dash (-) on hover.
<div
class="text-body-2 text-medium-emphasis"
style="max-width: 280px; overflow: hidden; text-overflow: ellipsis; white-space: nowrap;"
>
{{ item.description || '-' }}
<v-tooltip
v-if="item.description"
activator="parent"
location="top"
>
{{ item.description }}
</v-tooltip>
</div>
Fixes #7583.
Summary by Sourcery
Bug Fixes: