Skip to content

fix: revise reasoning_key attribute to OpenRouter#7821

Merged
Soulter merged 1 commit intomasterfrom
feat/openrouter-reasoning
Apr 26, 2026
Merged

fix: revise reasoning_key attribute to OpenRouter#7821
Soulter merged 1 commit intomasterfrom
feat/openrouter-reasoning

Conversation

@Soulter
Copy link
Copy Markdown
Member

@Soulter Soulter commented Apr 26, 2026

Modifications / 改动点

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Bug Fixes:

  • Align the OpenRouter provider's reasoning_key attribute with the expected reasoning field name.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 26, 2026
@Soulter Soulter merged commit d16ed4e into master Apr 26, 2026
20 checks passed
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since reasoning_key = "reasoning" looks provider-specific, consider defining this as a shared constant or configuration entry (similar to other providers, if any) so that changes to OpenRouter's reasoning field name can be managed centrally rather than hardcoded here.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `reasoning_key = "reasoning"` looks provider-specific, consider defining this as a shared constant or configuration entry (similar to other providers, if any) so that changes to OpenRouter's reasoning field name can be managed centrally rather than hardcoded here.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dosubot dosubot Bot added the area:provider The bug / feature is about AI Provider, Models, LLM Agent, LLM Agent Runner. label Apr 26, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a reasoning_key set to "reasoning" for the OpenRouter provider. A potential logic error was identified where this change might cause the base class to overwrite reasoning content extracted from message tags with an empty string if the specific API field is missing. It is recommended to modify the base class or override the extraction logic to ensure reasoning content is not lost.

Comment thread astrbot/core/provider/sources/openrouter_source.py
@Soulter Soulter deleted the feat/openrouter-reasoning branch April 26, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:provider The bug / feature is about AI Provider, Models, LLM Agent, LLM Agent Runner. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant