Merged
Conversation
Owner
|
Hello, Thank you for your contribution! I agree with the idea of allowing encoding of a PIL image, but rather than defining an additional function I suggest accepting an additional type in the already existing function def image_to_thumbhash(
image: Union[str, bytes, Path, BinaryIO, Image.Image],
) -> str:
if not isinstance(image, Image.Image):
image = Image.open(image) # For str, bytes, Path, BinaryIO we use the open() function
m_image = exif_transpose(image).convert("RGBA")
[...] |
Contributor
Author
|
Is there anything blocking you from merging it cc @Astropilot ? |
Astropilot
approved these changes
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.