This repository was archived by the owner on Jul 16, 2021. It is now read-only.
Merged
Conversation
This was referenced Sep 21, 2016
Contributor
|
Great! On 21 Sep 2016 7:00 p.m., "James Lucas" notifications@github.com wrote:
|
Owner
Author
|
Sorry that I had to merge this without you. We can start taking advantage of this new work now though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will resolve PR #117 .
This continues the great work by @tafia by taking into account new breaking changes from both rusty-machine ( #120 ) and rulinalg (variance returns result).
The changes are mostly minor - modifying imports. There are some structural changes to naive bayes to help error propagation. There is also a performance regression on the neural nets but this has been discussed in #117 . The short of it is:
applyis less efficient but there is an issue on rulinalg.hcatis less efficient on narrow matrices (as in the example) but more efficient on wide ones.We are also making modifications to the neural nets with #126 which will provide big performance gains.