pylibftdi returns str not bytes now #10
Open
tyler274 wants to merge 1 commit intoAtlasScientific:masterfrom
Open
pylibftdi returns str not bytes now #10tyler274 wants to merge 1 commit intoAtlasScientific:masterfrom
tyler274 wants to merge 1 commit intoAtlasScientific:masterfrom
Conversation
The decoding fails on the currently released verion of pylibftdi as it returns a `str` now instead of `bytes`.
benocd
approved these changes
Mar 7, 2022
benocd
left a comment
benocd
left a comment
There was a problem hiding this comment.
Had to do that workaround in order to make ftdi.py work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decoding fails on the currently released verion of pylibftdi as it returns a
strnow instead ofbytes.