Don't do a full path lookup on every individual emote button

[in1tiate]

This is a straight performance improvement, especially on characters with many emotes. There's potential for additional improvement here by using this m_character_path global in more places, but that's outside the scope of this PR.

It is absolutely insane that we were doing an entire asset lookup for every individual button.

[TrickyLeifa]

This pull request conflict with the VPath system's intended design. Currently, users can extend content (like emote icons that this patch is aiming at) without modifying the original files. This change would prevent that established functionality from working.

[in1tiate]

It is still possible to override the buttons, you just have to override all of them. The performance hit for doing individual folder lookups for every buttons is not worth the extremely niche functionality of customizing some but not all of a character's buttons.

[TrickyLeifa]

The performance cost of multiple path lookups is a known trade-off. This change fundamentally the design, forcing users to duplicate files across multiple folders just to retain existing functionality.

[in1tiate]

Please find me one user within the next week who is actively using the ability to override some but not all of a character's buttons with VPath and who would have their experience severely impacted by this change. Otherwise, hypothetical users don't trump measurable performance improvements. Appealing to the "design" is putting the cart before the horse.

[in1tiate]

never mind I think continuing to argue this point would take more hours off my life than I'd ever save with this performance improvement