placeSellTokenOrder & placeBuyTokenOrder

[szerintedmi]

No description provided.

[phraktle]

is this some autoformatting? did the settings change?

[szerintedmi]

yep i've noticed. it's happened before too. I suspect that @rszaloki doesn't have prettier format on save set or something else different in our editor. We should make sure we sync our setting

[phraktle]

as always, I suggest using integer bignums in lowest denomination (BN) consistently throughout the entire library, which would eliminate the need for the multiplication and integer checks below.

[szerintedmi]

1. We use BigNumber and not BN - which is already an issue. But web3.js is keep changing what do they use and how. There is an ongoing discussion about it. Shall we wait for that to settle before we refactor?

2. As always I'm for dev UX to augmint-js consumers.
   I.e. in case value can be represented with number then I would prefer

    exchange.placeSellTokenOrder(1.01, 100.12)

   over

   const decimalsDiv  = await exchange.token.decimalsDiv;
   exchange.placeSellTokenOrder(1.01, decimalsDiv.mul(100.12) )

Not a huge difference just seems easier.

[phraktle]

Linked in the proposal, ECMAScript BigInt seems to be best approach (being standardized in the language), with consideration given to more specialized sub-types (eg. wei). Since the point would be consistency, I'm happy to defer this to a later effort in a separate PR.

However, in the meantime let's at least get rid of the copy-pasted integrity checks and replace them with something that performs both unit conversions and integrity checks at the same time.

So instead of

const amountToSend: number = amount * DECIMALS_DIV;
if (Math.round(amountToSend) !== amountToSend) {
    throw new InvalidTokenAmountError(
        ` placeSellTokenOrder error: provided price of ${amountToSend} has more decimals than allowed by AugmintToken decimals of ${DECIMALS}`
    );
}

I would rather see something along the lines of:

const rawAmountToSend = AugmintToken.toRawAmount(amount);

(where the term raw would always mean numbers certain to be integers, in the lowest unit)

[szerintedmi]

sum of chat: we use BN class from bn.js (see ddb1121)