Skip to content

Start to use augmint-js #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phraktle merged 61 commits into from
May 9, 2019
Merged

Start to use augmint-js #597

phraktle merged 61 commits into from
May 9, 2019

Conversation

@szerintedmi
Copy link
Member

@szerintedmi szerintedmi commented Apr 26, 2019 •
edited by phraktle
Loading

Nature of the PR: chore

  • use websocket connection for local tests (required because HttpProvider is deprecating with web3 and augmint-js only supports websocket yet)
  • completely replaced ethers.js events with web3 events (not final way just first pass) 🚀
  • removed ethers.js dependency - not needed anymore 🚀
  • connect with EthereumConnection (given provider)
  • use augmint-js Exchange for matchMultipleOrders
  • use augmint-js Exchange.getOrders
  • use augmint-js placeBuyOrder and placeSellOrder

Bundle size

With augmint-js and removed ethers package

  481.8 KB   build/static/js/2.cbb8e226.chunk.js
  150.13 KB  build/static/js/main.4300dd41.chunk.js
  11.12 KB   build/static/css/main.e4a2fa00.chunk.css
  763 B      build/static/js/runtime~main.d653cc00.js

@szerintedmi
Copy link
Member Author

szerintedmi commented Apr 26, 2019 •
edited
Loading

Deploy preview for augmint ready!

Built with commit 6b00ec5

https://deploy-preview-597--augmint.netlify.com

szerintedmi and others added 28 commits April 26, 2019 07:29
@szerintedmi
Merge branch 'staging' into use_augmint_js
5ddb5c0
@szerintedmi
use augmint-js for matchMultipleOrders tx
30c3508
@phraktle
Merge branch 'staging' into use_augmint_js
43c4de2
@szerintedmi
revert accidental .yarnrc commit
908a47f
@szerintedmi
Merge branch 'use_augmint_js' of https://github.com/Augmint/augmint-web…
5c6d3e5 
… into use_augmint_js
@szerintedmi
adjust ethereum connection to new way
42e7f51
@szerintedmi
fix when user rejects tx signature
96c85f1
@szerintedmi
remove console.log
50bb8bf
@szerintedmi
use shiny new Augmint.create()
a48d1d9
@phraktle
Merge branch 'staging' into use_augmint_js
aacd727
@szerintedmi
Use augmint-js to get legacy exchanges & orders from them
0e18cbb
@szerintedmi
cleanup: no need for single match orders
4edf6a9
@szerintedmi
use augmint-js getOrder
004045f
@szerintedmi
Merge branch 'staging' into use_augmint_js
4491fc0
@szerintedmi
set augmint-js version
ed75106
@szerintedmi
remove unused
c420288
@szerintedmi
augmint-js to 0.1.1
b5075f5
@szerintedmi
tests: fix issueTo cypress commamd
972ae9d
@szerintedmi
use wss for local web3 connection
016e70e
@szerintedmi
use web3 events: rates
5b08008
@szerintedmi
user web3 events for user transfers
5ea0462
@szerintedmi
use web3 event: exchange orders & trades
eaaa8e2
@szerintedmi
use web3 events: legacyBalancesProvider
a7c2a68
@szerintedmi
use web3 events: loanManagerProvider
a2b1c28
@szerintedmi
handle loanproduct change events
01afe5b
@szerintedmi
use web3 events: lockManagerProvider
8484b75
@szerintedmi
use web3 events: preTokenProvider
caeee52
@szerintedmi
use web3 events: stabilityBoardProxyProvider
80d5a7e
phraktle
phraktle requested changes May 8, 2019
View reviewed changes
@szerintedmi szerintedmi requested a review from phraktle May 9, 2019 00:21
phraktle
phraktle requested changes May 9, 2019
View reviewed changes
Copy link
Contributor

@phraktle phraktle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only semantic question is if the duplicate event delivery is indeed a web3 bug. The rest is minor / stylistic.

phraktle
phraktle previously approved these changes May 9, 2019
View reviewed changes
@szerintedmi szerintedmi requested a review from phraktle May 9, 2019 08:55
@phraktle phraktle merged commit 59469eb into staging May 9, 2019
@phraktle phraktle deleted the use_augmint_js branch May 9, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phraktle phraktle phraktle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szerintedmi @phraktle