Skip to content

Conversation

@admrid
Copy link
Contributor

@admrid admrid commented May 14, 2019

Nature of the PR: bug

Steps to reproduce:

Trello card / screenshot / wireframe link:

Is connection necessary to test? If so which network?

  • local RPC
  • Rinkeby
  • Main Ethereum Network

@szerintedmi
Copy link
Member

szerintedmi commented May 14, 2019

Deploy preview for augmint ready!

Built with commit 96461ac

https://deploy-preview-630--augmint.netlify.com

@admrid admrid marked this pull request as ready for review May 21, 2019 10:49
Copy link
Contributor

@phraktle phraktle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I find the address shown in two lines strange. I would rather see it with a smaller font in a single line (or just the truncated ellipses version as in the header)

  • The "copy" link should look like a small button, or better yet, the usual clipboard copy icon (as seen on etherscan, for example)

  • Also, the top nav text is not vertically centered properly (more space on top than bottom).

Copy link
Member

@szerintedmi szerintedmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • too many decimal zeros in ETH balance

  • horizontal scroll in my account history on 320px

  • My total loans and total locks is breaking into two lines too early

Update: moved these to separate ticket #657

@admrid
Copy link
Contributor Author

admrid commented May 28, 2019

  • too many decimal zeros in ETH balance
  • horizontal scroll in my account history on 320px
  • My total loans and total locks is breaking into two lines too early

these are not really about the accountInfo comp.
and i am anyway refreshing the /account page so let's push them to that PR.
(there is tho one small fix coming related to the accInfo comp)

@szerintedmi
Copy link
Member

these are not really about the accountInfo comp.
and i am anyway refreshing the /account page so let's push them to that PR.
(there is tho one small fix coming related to the accInfo comp)

Right, moved to #657

@admrid admrid requested a review from phraktle May 30, 2019 15:19
@admrid
Copy link
Contributor Author

admrid commented May 31, 2019

@phraktle
i think this can be merged now.
all the other points of yours are going to be addressed in another PR

@phraktle
Copy link
Contributor

@admrid is the design change making the upper right panel white instead of the previous yellow intentional or a bug?

@admrid
Copy link
Contributor Author

admrid commented Jun 3, 2019

@phraktle
intentional:
i think for now it is good to have those pieces of information presented there,
but those should not take the focus off from the main content/actions of the app,
hence there is no need for those to be visually this strong.

@phraktle phraktle changed the title accountInfo fixes Improve top nav and account overview layout Jun 3, 2019
@phraktle phraktle merged commit e9c6920 into staging Jun 3, 2019
@phraktle phraktle deleted the aeurtag branch June 3, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A€ symbol for total loan / lock amount is breaking to new line on my account page Balance decimals on account page shown without trailing 0

4 participants