Landing page redesign #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Deploy preview for augmint ready! Built with commit db2c273 |
phraktle
requested changes
May 21, 2019
Contributor
phraktle
left a comment
phraktle
left a comment
There was a problem hiding this comment.
Looks good, with a minor cleanup suggestion.
|
|
||
| import { BalanceIcon, InterchangeIcon } from "components/Icons"; | ||
|
|
||
| import { keyFeatures, keyBenefits, howItWorks } from "./helpers.js"; |
Contributor
There was a problem hiding this comment.
If we're no longer using these, let's remove these from helpers.js as well.
Member
|
Could we get rid of the "How to get Rinkeby test ethers" embedded video from the how to connect page as part of this PR? |
phraktle
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nature of the PR: bug/feature/chore
Steps to reproduce:
Trello card / screenshot / wireframe link:
Is connection necessary to test? If so which network?