update CANCEL_ORDER_GAS estimate #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increased gas estimate from 70k to 90k due to occasionally running out of gas on rinkeby (see links in comments)
Member
Author
|
Deploy preview for augmint ready! Built with commit 5d075d7 |
phraktle
approved these changes
May 22, 2019
Contributor
phraktle
left a comment
phraktle
left a comment
There was a problem hiding this comment.
Ok, though the increase was to 100k, not 90k as stated :)
Also, it would be better to add the cancel call to augmintjs instead, so this constant is not in the UI.
Member
Author
where ? ;)
sure, it's a quick fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increased gas estimate from 70k to 100k due to occasionally running out of gas on rinkeby (see links in comments)
Nature of the PR: bug/feature/chore
Steps to reproduce:
Trello card / screenshot / wireframe link:
Is connection necessary to test? If so which network?