Skip to content

Conversation

@brigittaforrai
Copy link
Contributor

Nature of the PR: feature

Steps to reproduce:

In safari browser go to the landing page then click on eg. start loan process button.

Is connection necessary to test? If so which network?

  • local RPC
  • Rinkeby
  • Main Ethereum Network

@szerintedmi
Copy link
Member

szerintedmi commented May 24, 2019

Deploy preview for augmint ready!

Built with commit 8a4a482

https://deploy-preview-647--augmint.netlify.com

@brigittaforrai brigittaforrai requested a review from rszaloki May 30, 2019 10:43
@phraktle phraktle requested review from admrid and phraktle June 4, 2019 09:53
admrid
admrid previously requested changes Jun 4, 2019
Copy link
Contributor

@admrid admrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's full of commented out lines...

Copy link
Contributor

@phraktle phraktle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this ticket needs now is a clear title that describes what has changed functionally :)

@rszaloki rszaloki changed the title Connection redesign Connect to wallet should occur after the disclaimer popup accepted Jun 6, 2019
@phraktle phraktle dismissed admrid’s stale review June 6, 2019 18:08

comments were removed

@phraktle phraktle merged commit 9295e3e into staging Jun 6, 2019
@phraktle phraktle deleted the connectionRedesign branch June 6, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants