Skip to content

Conversation

@ejulcsi
Copy link
Contributor

@ejulcsi ejulcsi commented Jun 11, 2019

No description provided.

@szerintedmi
Copy link
Member

szerintedmi commented Jun 11, 2019

Deploy preview for augmint ready!

Built with commit a4ec0d8

https://deploy-preview-673--augmint.netlify.com

@phraktle phraktle self-requested a review June 12, 2019 12:05
Copy link
Contributor

@phraktle phraktle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejulcsi please restore the address and amount parameters in the link.

@phraktle phraktle self-requested a review June 14, 2019 21:17
@phraktle phraktle dismissed their stale review June 14, 2019 21:18

stale

Copy link
Contributor

@phraktle phraktle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass address / amount based on this document: https://gist.github.com/debreczeni/0e9b7bfc6d9e32715db63aa937f7cb18

@phraktle phraktle requested a review from rszaloki June 18, 2019 09:47
@phraktle phraktle changed the title change mrcoin link Update MrCoin exchange links Jun 18, 2019

minMrCoinAEurAmount: value => {
return value < 15 ? `Amount must be at least: 15 A-EUR` : undefined;
minMrCoinAmount: (minvalue, currency) => value => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be just minAmount

this.state = {
orderDirection: ADDFUND,
amount: "",
minEUR: Validations.minMrCoinAmount(FUNDS[0].eurLimit, "EUR"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be in state (use a const or move it to funds.js)

@phraktle phraktle requested a review from rszaloki June 18, 2019 11:57
@phraktle phraktle removed the request for review from rszaloki June 18, 2019 12:00
@rszaloki rszaloki merged commit c2a22f6 into staging Jun 18, 2019
@phraktle phraktle deleted the fiat-xchg-link branch June 18, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants