Skip to content

impl support for text modifications #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AustinJ235 merged 74 commits into from
Oct 24, 2025
Merged

impl support for text modifications #59

AustinJ235 merged 74 commits into from
Oct 24, 2025

Conversation

@AustinJ235
Copy link
Owner

@AustinJ235 AustinJ235 commented Oct 20, 2025

This pull request introduces TextBodyGuard which is used for text body modification.

This is required for the TextEntry, TextEditor and CodeEditor widgets coming soon...

AustinJ235 added 30 commits April 28, 2025 00:02
@AustinJ235
impl 'get_text_cursor'
e6f28f9
@AustinJ235
impl basic text editing
22f65a4
@AustinJ235
sort of fix byte_s & byte_e when new lines occur
a3fb043
@AustinJ235
fix empty lines
750fa5e
@AustinJ235
make get_cursor more robust
c740762
@AustinJ235
sort of fix selecting empty lines
9e2f360
@AustinJ235
actually fix selecting empty lines
472683c
@AustinJ235
add basic display cursor
0d1987e
@AustinJ235
some minor fixes
55427de
@AustinJ235
mockup some methods on TextBody
3b43c90
@AustinJ235
Various
4ac3041 
- impl `is_valid_cursor`, `cursor_prev` & `cursor_next`
- Refactor line start/end cursors to handle char byte offsets and wrapped lines correctly.
- Refactor cursor display to be more accurate and handle new lines better.
@AustinJ235
impl cursor_delete, cursor_insert & push
ac20fd6
@AustinJ235
impl basic selection
4005af1
@AustinJ235
impl selection_value
2ea7d70
@AustinJ235
Fix end/start of line cursors from being displayed incorrectly.
76971b1
@AustinJ235
Fix line_byte_mapping
557ae86
@AustinJ235
TextCursor Changes
2d8d383 
- Turn `TextCursor` into an enum.
- Allow Cursor to be displayed even when the body is empty.
- Remove text test example as that is no longer needed. (See basalt-widgets repo)
@AustinJ235
Add Bin::get_text_cursor_bounds
3a12995
@AustinJ235
Fix Bin content scrolling.
d2864be 
- Fixed issue where scrolling was not being applied to content. (text & user vertexes)
- Make cursor_bounds return [MIN_X, MAX_X, MIN_Y, MAX_Y] instead of [MIN_Y, MAX_Y, MIN_X, MAX_X] to be consistent with other api's.
- Fix get_text_cursor_bounds calculating tlwh incorrectly.
@AustinJ235
impl style_modify_then
3e4c1d3
@AustinJ235
Bin: use read_recursive instead of read.
800d4c6 
Calling various getter methods of `Bin` while using methods that take a closure could result in deadlocks.
@AustinJ235
impl selection_delete
1e9918d
@AustinJ235
add some docs
90b5dde
@AustinJ235
disable ligatures as they break selection
fd59a73
@AustinJ235
fix deadlock in style_modify_then
095b288
@AustinJ235
fix content overflow calc from including scrolling
d26e63c
@AustinJ235
impl text_cursor_up & text_cursor_down
208ceb2 
- Add docs for `get_text_cursor` & `get_text_cursor_bounds`.
- Fix potential deadlock in `get_text_cursor_bounds`.
- Fix `get_text_cursor_bounds` from using the `TextBody`'s cursor instead of the one provided.
@AustinJ235
Refactor text layout to provide more accurate start/end of line cursors.
1a4cf0c 
This fixes an issue where if the cursor is moved up or down at the end of the line when text was wrapped it would be moved incorrectly.
@AustinJ235
impl select_word & select_line
e8d2955
@AustinJ235
Refactor text selection/deletion
75c26c4 
- replace `selection_value` with `selection_string`
- refactor `selection_delete`
- impl `selection_spans`
- impl `selection_take_spans`
- impl `selection_take_string`
- mockup `cursor_insert_string` & `cursor_insert_spans`
@AustinJ235
cleanup a bit
c2ffdc3
@AustinJ235
some fixes
7a78c47
@AustinJ235
fix deadlock
6e26b1b
@AustinJ235
Move cursor & selection structs to text_body mod.
aa0bddf
@AustinJ235
remove old methods
14b13d1
@AustinJ235
impl shrink_selection
6bf53b3
@AustinJ235
impl selection_apply_attrs & span_apply_attrs
8333d6c
@AustinJ235
initialize render's UpdateContext from window's shared UpdateContxt
4b3f2a8
@AustinJ235
fix update_layout
1d9d32d
@AustinJ235
rework cursor_word_*
08384cd
@AustinJ235
rework word_ranges to work with multi-span words
33a48c3
@AustinJ235
rework cursor_select_word
083f3fb
@AustinJ235
add TextSelection::unordered & remove shrink/extend
ed2dbf9
@AustinJ235
fix is_selection_valid & check if selection is valid for `selection…
d4b2228 
…_delete`
@AustinJ235
impl TextBodyGuard::cursor_line_offset
e52afb1
@AustinJ235
rename text_modify mod to text_guard.
2e4b7f3
@AustinJ235
oops
8db8129
@AustinJ235
fix cursor_line_start & cursor_select_line when display_lines i…
be49f10 
…s false
@AustinJ235
make get_cursor more intuitive when selecting below or above body
0535677
@AustinJ235
update children when a floating Bin is dropped
5868c3d
@AustinJ235
fix on_hold not removing hook when target is dropped
31d6496
@AustinJ235
Fix cursor_line_column & line_column_cursor when as_displayed i…
0f34f47 
…s `false`
@AustinJ235
Fix cursor_line_start & cursor_line_end when as_displayed is `f…
86fa45a 
…alse`
@AustinJ235
Fix alignment when TextHoriAlign::Right is used
22ddd8f
@AustinJ235
update changelog
5f8046d
@AustinJ235
change lock order in obtain_vertex_data to avoid deadlocks
9717b3f
@AustinJ235
fix horizonal scrolling
f384226
@AustinJ235
fix horizonal scrolling some more
91663eb
@AustinJ235
add fallback case for line_column_cursor
22741b5
@AustinJ235 AustinJ235 merged commit 1c87970 into master Oct 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AustinJ235