Add Typescript and Jest #40
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I wasn't originally going to add Typescript, but I was having trouble getting Jest to understand Unfortunately, I still ran into troubles, as shown by the TODO statement added in the second commit here. I'll try to circle back to this soon. |
Merged
The setup here closely follows the instructions at https://jestjs.io/docs/en/getting-started One of the trickiest things to note is the `api.env('test')` check in `.babelrc.js` – we need this to be `false` for our build script, but `commonjs` for testing. This is what necessitated changing `.babelrc` to a full js file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal: add typescript and jest, so we can have the safety of both a type-checker and our own automated tests.
To do