Decoupled Projects fixes #2002
Merged
Decoupled Projects fixes #2002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch id over to issue ID from issue number - ensure repo ID stays consistent fro decoupled issues - ensure issue shape stays consistent through entire lifecycle
I noticed that the "Link" component inside the submission and application text wasn't displaying inline. I had to add an "href" prop to get it to render as a proper link element (as opposed to a button element) and that allowed me to get all submission text inline with the IdentityBadge and wrapping as expected
ghost
requested review from
PeterMPhillips
requested changes
May 22, 2020
Member
PeterMPhillips
left a comment
PeterMPhillips
left a comment
There was a problem hiding this comment.
Right now when I submit an application and it gets accepted, the work flow doesn't progress any further. I'm unable to submit work.
| ...ipfsData, | ||
| repoId: hexToAscii(repoId), | ||
| repoHexId: repoId, | ||
| token: ipfsData.token.addr |
Member
There was a problem hiding this comment.
ipfsData.token is undefined when a decoupled issue is first created, so this causes the store to fail when creating an issue, I wrote this to get past the error: token: ipfsData.token ? ipfsData.token.addr : null but maybe you have a better way.
topocount
force-pushed
the
projects-settlement-fixes
branch
from
ddc3205 to
3aec762
Compare
PeterMPhillips
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes DEV-190
fixes DEV-189
fixes DEV-165
fixes DEV-161