fix: Turn off Poetry modern installer #300
Merged
Merged
Conversation
…tion to false. This correct an issue with and invalid debugpy wheel with Poetry v1.4.1 modern installer.
benwandrew
approved these changes
Mar 21, 2023
Collaborator
benwandrew
left a comment
benwandrew
left a comment
There was a problem hiding this comment.
looks good (for now?)!
Member
|
this is related to python-poetry/poetry#7686 |
musslick
approved these changes
Mar 23, 2023
Collaborator
musslick
left a comment
musslick
left a comment
There was a problem hiding this comment.
Makes sense and looks good!
Collaborator
Author
|
@hollandjg Should we merge this or continue to wait? |
Collaborator
Author
|
Been following this issue. Seems like Poetry updated so that it will warn invalid wheels instead of failing. This fix has been released with the Poetry 1.4.2 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects an issue with an invalid
debugpywheel with Poetry v1.4.1 modern installer. This was causing an issue during GitHub action pytests package installation.Description
Provide a high-level summary of the change and which issue (either on Github or Notion) is fixed. Please also include relevant motivation and context.
Fixes #(issue) (if the issue is on Github, simply link to it using the '#' symbol; otherwise, provide a notion page link)
Type of change:
Features:
Questions: