Show median values in aggregated charts by default #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches all charts with the “first” aggregation strategy to “median” aggregation. Previously, chart views with aggregated data just showed the first value of each time period. The median value might be a better choice, because it is more representative of the data than just picking the first value available. The arithmetic mean was also considered as a choice, but is expected not to even out sporadic effects such as public holidays as nicely as the median function.
larsxschneider
approved these changes
Apr 23, 2018
Collaborator
larsxschneider
left a comment
larsxschneider
left a comment
There was a problem hiding this comment.
Nice! Great way to ignore the effects of weekends and public holidays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches all charts with the
firstaggregation strategy tomedianaggregation.Previously, chart views with aggregated data just showed the first value of each time period. The median value might be a better choice, because it is more representative of the data than just picking the first value available. The arithmetic mean was also considered as a choice, but is expected not to even out sporadic effects such as public holidays as nicely as the median function.