git-download: fix GHE version detection #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An exit code of 0 indicates success and an exit code of 1 indicates failure in bash. Flip the version comparision operator in Perl to implement "ghe_greater_equal" properly. In addition, define the required version with three segments as this seems to be required by the Perl version parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An exit code of 0 indicates success and an exit code of 1 indicates
failure in bash. Flip the version comparision operator in Perl to
implement "ghe_greater_equal" properly.
In addition, define the required version with three segments as this
seems to be required by the Perl version parser.
Thanks to @toddocon for pointing out the issue to me!
Unfortunately, this does not yet fix the download graph for GHE 2.11.
It looks like the log rotation frequency for /var/log/github-audit.log
changed from daily to weekly. I've asked GH support if this change
was intentional. If yes, then we need to adjust our audit log data
gathering as the current code expects the daily rotation.