Skip to content

Reporting fix for node initial Run#693

Merged
mahbd merged 9 commits intodevfrom
report
May 10, 2026
Merged

Reporting fix for node initial Run#693
mahbd merged 9 commits intodevfrom
report

Conversation

@Muntasib-creator
Copy link
Copy Markdown
Collaborator

Summary:

When a zeuz node is downloaded and run for the first time, It might happen that settings.conf inside framework file was imported before the file is created. This invokes an reporting error. The error is fixed

@Muntasib-creator Muntasib-creator self-assigned this May 6, 2026
@Muntasib-creator Muntasib-creator requested a review from mahbd May 6, 2026 11:40
@Antu7
Copy link
Copy Markdown
Collaborator

Antu7 commented May 6, 2026

🔎 ZeuZ PR Review

Open the full report in ZeuZ: Review findings and apply suggestions

Overview Value
Agents ✅ 4 completed
Suggestions 💡 2

Agent breakdown

→ General Review

Status: ✅ Completed
Suggestions: 0 suggestions

No actionable issues found in the PR diff; the change appears consistent with the reporting fix and updated call sites in CommonUtil.py.

→ Security Review

Status: ✅ Completed
Suggestions: 0 suggestions

No security findings in this PR diff. The changes are limited to refactoring the temp config path helper and updating call sites, with no new auth, injection, or data exposure risks introduced.

→ Performance Review

Status: ✅ Completed
Suggestions: 1 suggestion

The PR introduces a hot-path config lookup regression by turning temp_config into a function that re-reads settings on every log/report call; caching the computed path avoids repeated file I/O in logging-heavy code.

→ Testing Review

Status: ✅ Completed
Suggestions: 1 suggestion

The change fixes a real lazy-evaluation bug, but it adds no regression coverage for the reporting/logging path that depended on temp_config(). A focused test should lock in the new behavior and prevent the original failure from returning.

Open ZeuZ to inspect full findings, continue an agent conversation, or apply safe patch suggestions.

mahbd
mahbd previously requested changes May 7, 2026
Copy link
Copy Markdown
Collaborator

@mahbd mahbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several other files where temp_config is still being used the old way. I think those should be changed in the same way as well.

@mahbd mahbd dismissed their stale review May 10, 2026 03:48

Those won't cause any problem

@mahbd mahbd merged commit 8973470 into dev May 10, 2026
7 checks passed
@mahbd mahbd deleted the report branch May 10, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants