Conversation
To loose unnecessary constraint
ParaskP7
left a comment
ParaskP7
left a comment
There was a problem hiding this comment.
👋 @wzieba !
I have reviewed (and also tested this PR), everything looks and work as expected, good job! 🌟
FYI: Although I (think) understand why you are not adding testing instruction, me having a Sentry test account, just like you, makes it "easy" to test should PRs. Consider in the future to add some testing instructions, even if that's "optional". This will save me time and effort to try and figure out what to test myself, or whether I tested at least what the PR author wanted me to test.
PS: Let me know when BPAndroid#2826 is ready.
I have left one suggestion (💡) for you to consider. I am going to approve this PR anyway, since none is blocking. I am NOT going to merge this PR yet to give you some time to apply any of my suggestions. However, feel free to ignore them and merge the PR yourself.
...a/com/automattic/android/tracks/crashlogging/performance/PerformanceTransactionRepository.kt
Outdated
Show resolved
Hide resolved
|
|
||
| object PerformanceMetricsTag { | ||
| @JvmStatic | ||
| fun Modifier.tagForPerformanceMetrics(tag: String) = this then sentryTag(tag) |
There was a problem hiding this comment.
Praise (❤️): TIL about the then infix function on a modifier!
|
Just reiterating my support here - did a run through of the APIs on the consumer side and everything is looking good 👍 |
3 participants
Description
This PR adds or exposes several new features for performance measurments:
PerformanceMetricsTagfor measuring performance of composeRelated internal request: pdnsEh-1Lf-p2