[Dependency Analysis] Remove Unused Dependencies#275
Merged
Conversation
FYI: After updating the 'dependency-analysis' plugin to '2.19.0', as part of #272, this plugin started working better than before ('1.33.0') and thus created this new advise that was previously ignored, since indeed there is no 'import androidx.annotation.*' import on this 'crashlogging' module. PS: The only such one 'import androidx.annotation.*' import exist on the 'AutomatticTracks' module, because it (seems) that it is the only module that is still using Java classes. PR: #272 ------------------------------------------------------------------------ This removal was suggested by the dependency analysis report, see below: Advice for :crashlogging Unused dependencies which should be removed: implementation 'androidx.annotation:annotation:1.7.0'
There was a problem hiding this comment.
Pull Request Overview
This PR removes an unused androidx.annotation dependency from the crashlogging module as identified by the upgraded dependency-analysis plugin (v2.19.0). The plugin now more accurately detects that this annotation library is not imported or used within the crashlogging module.
- Removes unused
androidx.annotation:annotationdependency from crashlogging module - Cleans up build.gradle file by removing unnecessary blank line
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
wzieba
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: AINFRA-1181
Description
This PR Removes this unused
androidx.annotationdependency from thecrashloggingmodule.FYI: After updating the
dependency-analysisplugin to2.19.0, as part of #272, this plugin started working better than before (1.33.0) and thus created this new advise that was previously ignored, since indeed there is noimport androidx.annotation.*import on thiscrashloggingmodule.PS: The only such one
import androidx.annotation.*import exist on theAutomatticTracksmodule, because it (seems) that it is the only module that is still using Java classes.Testing Instructions
./gradlew buildHealthtask and verify that there is nounusedrelated advise remaining within both reports, JSON and txt included:build-health-report.json-> Search forunusedCountbuild-health-report.txt-> Search forunusedunusedrelated advises.Optional):cp gradle.properties-example gradle.propertiesand set a validsentryTestProjectDSN, using thetracks-demo-androidproject on A8C Sentry.