[CI] Fix Slack Notify Configuration in Dependency Analysis Pipeline#295
Open
[CI] Fix Slack Notify Configuration in Dependency Analysis Pipeline#295
Conversation
Move notify block from step level to pipeline level and add both passed and failed notifications with explicit messages. Step-level notify only supports a subset of conditions, while pipeline-level notify properly triggers on build state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Ignore the .kotlin directory which contains temporary kotlin compiler session files that should not be tracked. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the Buildkite scheduled dependency analysis pipeline to ensure Slack notifications are correctly sent by moving notify from step-level to pipeline-level (where build.state conditions are supported).
Changes:
- Add
.kotlin/to.gitignoreto ignore Kotlin compiler session artifacts. - Move Slack notifications to pipeline-level
notifyand add explicitpassed/failedmessages to#android-core-notifs.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.gitignore |
Ignores Kotlin compiler session directory (.kotlin/). |
.buildkite/schedules/dependency-analysis.yml |
Moves Slack notifications to pipeline-level and adds explicit success/failure notifications gated by build.state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: AINFRA-2126
Description
Step-level
notifyin Buildkite only supports a subset of conditions, so thebuild.state == "failed"condition was silently ignored and no Slack notifications were being sent when the dependency analysis pipeline failed. This was originally discovered and fixed in WordPress-MediaPicker-Android#90 (commit 7d002b6).This PR applies the same fix by moving the
notifyblock from step level to pipeline level and adding bothpassedandfailednotifications with explicit messages to#android-core-notifs.Testing Steps
Trigger Standalone "Dependency Analysis" JobHEADci/fix-slack-notify-in-dependency-analysis-pipelinePIPELINE=schedules/dependency-analysis.yml#android-core-notifs