Disable automatic breadcrumb tracking by default#114
Merged
Conversation
frosty
approved these changes
Oct 29, 2019
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Just one clarifying question, which I added to the WPiOS PR 🙂
jkmassel
force-pushed
the
disable/automatic-breadcrumb-tracking-by-default
branch
from
7f22818 to
c68976b
Compare
jkmassel
force-pushed
the
disable/automatic-breadcrumb-tracking-by-default
branch
from
c68976b to
8a26aad
Compare
jkmassel
force-pushed
the
disable/automatic-breadcrumb-tracking-by-default
branch
from
8a26aad to
679f849
Compare
jkmassel
deleted the
disable/automatic-breadcrumb-tracking-by-default
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change, apps must explicitly opt in to breadcrumb tracking – if they don't, nothing happens.
This PR can be tested with wordpress-mobile/WordPress-iOS#12778