Skip to content

Remove nil coalescing for non-optional value in CrashLogging#145

Merged
mokagio merged 1 commit intodevelopfrom
fix/left-side-nil-coalescing-not-nil
Sep 10, 2020
Merged

Remove nil coalescing for non-optional value in CrashLogging#145
mokagio merged 1 commit intodevelopfrom
fix/left-side-nil-coalescing-not-nil

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Sep 7, 2020

The code generated this warning:

Left side of nil coalescing operator '??' has non-optional type
'Bool', so the right side is never used

I noticed it while working on AutoProxxy.

@mokagio mokagio marked this pull request as ready for review September 7, 2020 11:41
Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The code generated this warning:

> Left side of nil coalescing operator '??' has non-optional type
> 'Bool', so the right side is never used
@mokagio mokagio force-pushed the fix/left-side-nil-coalescing-not-nil branch from 50a1db7 to bd3d61b Compare September 10, 2020 05:03
@mokagio mokagio merged commit 5f96537 into develop Sep 10, 2020
@mokagio mokagio deleted the fix/left-side-nil-coalescing-not-nil branch September 10, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants