Closed
Conversation
That's because the CI for Xcode 12 doesn't support the current version of Bundler. See https://app.circleci.com/pipelines/github/Automattic/Automattic-Tracks-iOS/370/workflows/0712811a-2403-4555-8562-36914fd831f2/jobs/898
The project changes were made by the Xcode upgrade wizard.
This will allow us to add the conditional logic for the sandbox vs non-sandbox location later on.
We'll need this later to make the custom init with the sandbox mode flag non-nullable.
This should have always been the case, but somehow I got confused and didn't realize my mistake. Thanks @jleandroperez for picking this up! Goes to show that tests are only good when written properly! https://github.com/Automattic/Automattic-Tracks-iOS/pull/147/files/3e38df8087e7b38a76b45acc5e89527746b4145b#r498830462
From CLI, running the tests might prompt for ~/Documents folder access because they run outside of the sandbox. If access is not granted, the tests might fail. For example, see https://app.circleci.com/pipelines/github/Automattic/Automattic-Tracks-iOS/368/workflows/1f76b1d9-b2df-4a17-b2e5-aae3ad436594/jobs/890
This reverts commit 605b3ff.
The Sodium-Fork pod we're using is something I just released, we need to fetch it in order for the validation to pass. See https://app.circleci.com/pipelines/github/Automattic/Automattic-Tracks-iOS/380/workflows/c0206d34-0f8a-4913-8b5d-b05e6dcb7c5b/jobs/936 (Search the output for "Sodium-Fork")
The build failed despite the command to update the pod repo (although it took 1s to run and didn't emit any output – did it run at all??) Trying this to see if it updating the library shakes things up enough to fetch up-to-date specs
There was an error in how CocoaPods generated the module name that would have resulted in the need to update all of the `import Sodium` calls to `import SodiumFork`.
…lds" This reverts commit 7208b15.
Contributor
Author
|
This was a PR to get some tests to run on CircleCI. It's done its job. Closing it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.