Switch back to Sodium's original library & update to 0.9.0#157
Closed
Switch back to Sodium's original library & update to 0.9.0#157
Conversation
…ologies Remove references to whitelist/blacklist
This is required to make the pod build with Xcode 12.2, otherwise we'd get the following error: > xcodebuild: > Sentry/Sources/SentryCrash/Recording/Tools/SentryCrashObjC.c:198:54: > error: use of undeclared identifier 'kCFCoreFoundationVersionNumber_iOS_8_x_Max'
mokagio
force-pushed
the
switch-back-to-sodium-trunk
branch
from
8d710e6 to
2da8c85
Compare
Contributor
Author
|
The validation fails with warnings only. |
This is a key required update to properly work with XCFrameworks, which is what the Sodium library uses to distribute its static library in a way that is compatible with Apple Silicon (see version 0.9.0 of the library).
This is a requirement to update Sodium to the version compatible with Apple Silicon. I tried using 11.0 as well, but that didn't work.
Now that CocoaPods 1.10.0 is out, we can go back to the original Sodium library and decommission the fork we've been recently to work around some Apple Silicon related limitations. You can verify this works by running ``` bundle exec pod lib lint --allow-warnings ``` For extra context see: - jedisct1/swift-sodium#213 - jedisct1/swift-sodium#214 - #148
mokagio
force-pushed
the
switch-back-to-sodium-trunk
branch
from
2da8c85 to
044dad6
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a demo PR with a version of Tracks that builds for macOS targets on Xcode 12.2.
I don't consider it ready for merge because of the huge dependency of updating Tracks to version 5.0. Something on which @jkmassel also worked on (#131) but that I didn't realize when I worked on this.
It's handy to have the code online so that we can point to this branch in our macOS targets and use this PR for Sodium related discussions.