Skip to content

Add CHANGELOG.md#234

Merged
mokagio merged 3 commits intotrunkfrom
mokagio/add-changelog
Oct 19, 2022
Merged

Add CHANGELOG.md#234
mokagio merged 3 commits intotrunkfrom
mokagio/add-changelog

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Oct 19, 2022

Adds CHANGELOG.md. Based on wordpress-mobile/WordPressKit-iOS#545 and the PR template iteration from wordpress-mobile/WordPressUI-iOS#119.

@mokagio mokagio force-pushed the mokagio/add-changelog branch from 2a8745c to 300c44a Compare October 19, 2022 10:06
@mokagio mokagio enabled auto-merge October 19, 2022 10:07
@mokagio mokagio requested a review from a team October 19, 2022 10:11
When releasing a new version:

1. Remove any empty section (those with `_None._`)
2. Update the `## Unreleased` header to `## [<version_number>](https://github.com/wordpress-mobile/Automattic-Tracks-iOS/releases/tag/<version_number>)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch updating this URL on every PR you make to add those CHANGELOGs in our lib repos each time… it could be so easy to miss when doing a quick copy/paste, so kudos for the attention to detail 🙂 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually... While working on the tumblr/Kanvas-iOS one, I realized I didn't update the org part of this GitHub URL 😓

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And somehow we both missed that, even after I commented on that exact line about that URL saying it was the right one 🤦
We both need to update our coffee blend to stronger beans it seems 😄 ☕ ☕ ☕

@mokagio mokagio merged commit 9f59c6e into trunk Oct 19, 2022
@mokagio mokagio deleted the mokagio/add-changelog branch October 19, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants