Refactor ExPlat assignments endpoint unit tests#256
Draft
salimbraksa wants to merge 7 commits intotrunkfrom
Draft
Refactor ExPlat assignments endpoint unit tests#256salimbraksa wants to merge 7 commits intotrunkfrom
salimbraksa wants to merge 7 commits intotrunkfrom
Conversation
salimbraksa
changed the title
crazytonyli
requested changes
May 5, 2023
Contributor
crazytonyli
left a comment
crazytonyli
left a comment
There was a problem hiding this comment.
Thanks for considering my suggestion. I think these properties can now be removed?
| } | ||
|
|
||
| private func makeTracksService(platform: String?, eventNamePrefix: String?) -> TracksService? { | ||
| guard let tracksService = TracksService(contextManager: MockTracksContextManager()) else { |
Contributor
There was a problem hiding this comment.
I don't think it's possible that the tracksService would be nil?
| let platform = "wooios_test" | ||
| let token = "abc" | ||
| let expectedEndpoint = Self.makeAssignmentsEndpoint(platform: platform, experiment: experiment) | ||
| stub(condition: isAbsoluteURLString(expectedEndpoint)) { request in |
Contributor
There was a problem hiding this comment.
This condition is probably too strict. The query part in the expectedEndpoint probably won't exactly match the requested URL string. I think it's best to compare the path part in the condition, and assert the request.url contains certain query?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to address the following feedback:
OHHTTPStubsto assert that the ExPlat assignments request contains appropriate values.trackServiceto the test methods.CHANGELOG.mdif necessary.