Add a "No Access" badge to subscribers that will not be able to receive notifications#461
Conversation
|
Hi all, I'm not sure of the best way for me to fix the conflicting files problem. If someone could tell me the basic steps I need to take to submit an update to something like this that would be appreciated (i.e. starting from my own forked master, what do I do?) I got it working on my local setup, alongside #449 and current I'm a bit out of my depth with the git here, trying to test all these things together, sorry. The main, non-merge-related problem is that this totally breaks the display of #452 because this changes the HTML structure of the checkbox area, on which #452 depends. This jQuery replacement in subscribed_users.each( function() {
- usernames.push( $( this ).next().text() );
+ usernames.push( $( this ).parent().siblings('.ef-user_displayname').text() );
} );The earlier one was a bit brittle overall in retrospect. Maybe someone else can come up with a more robust version of my jQuery, but you get the idea. Without this, merging Going to try to submit this as a PR somehow. |
|
@rinatkhaziev Please see PR above, it's vital to get it in before any release, as this whole feature is currently broken without the fix. |
For #451
Recap of what's being done in this PR:
I prototyped a bit ahead, thinking of how #273 could be implemented. So some of the organization here had those changes in mind.
Also note that I added the
user_can_be_notified()method in for testing purposes, but can remove/leave out when it comes to merging into the feature branch.Screenshot:
