editorial-comments.js - fix jQuery that updates notified list#488
Merged
rinatkhaziev merged 1 commit intoAutomattic:masterfrom Jan 2, 2019
Merged
Conversation
… users The jQuery used to get the text from the node next to the textbox (username) There is now an extra div around the checkbox, so this is broken. New jQuery gets the parent of the checkbox, then searches it's siblings for the displayname and uses that
Contributor
Author
|
@rinatkhaziev @sboisvert Pls review this one. It's a pretty obvious fix. |
rinatkhaziev
approved these changes
Jan 2, 2019
Contributor
|
@jerclarke Thanks, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update jQuery that pulls text from subscribed users
This is a fix for the already-merged #461 already described in a comment there:
#461 (comment)
Currently the "notified list" feature is totally broken.
WHAT THIS CHANGES