Hooks logic fails for short array syntax

[GaryJones]

Changing to short array syntax in Tests/Hooks/AlwaysReturnInFilterUnitTests.inc and Tests/Hooks/PreGetPostsUnitTests.inc result in those tests failing.

It suggests that some of the processing logic in each sniff is flawed for short array syntaxes.

Both long and short array syntax should be retained in the unit tests.

Environment

Use php -v and composer show to get versions.

Question	Answer
PHP version	7.2.0
PHP_CodeSniffer version	3.4.0
VIPCS version	master

Tested Against master branch?

• I have verified the issue still exists in the master branch of VIPCS.

[GaryJones]

The line of logic is:

elseif ( 'T_ARRAY' === $this->_tokens[ $callbackPtr ]['type'] )

which presumably misses checking for an array of the [ ... ] form.

[GaryJones]

It's not as simple as adding a check for T_OPEN_SHORT_ARRAY.

Ideally, we want to be able to use this WPCS method to accurately handle this.

See #359 for how this might be possible.

[GaryJones]

Now that #377 is merged, we can use the WPCS method to fix/improve our sniff.

[GaryJones]

WPCS 3.0 will likely that utility method, as it will depend on the utility methods in PHPCSUtils instead.

Good news is, after #474 is done, we can use these PHPCSUtils utility methods ourselves.

• Long array syntax currently in the test file
• AlwaysReturnInFilterSniff