Skip to content

Update output when dbDelta is found in the codebase #479

@BrookeDot

Description

@BrookeDot

What problem would the enhancement address for VIP?

When a codebase is scanned and dbDelta is found the following error is output:

All database modifications have to approved by the WordPress.com VIP team.

https://github.com/Automattic/VIP-Coding-Standards/blob/master/WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php#L94

While this was previously true on WordPress.com we no longer require the VIP team to approve all database changes at every code review level.

Describe the solution you'd like

As this can still cause performance problems, we should continue to flag this as a possible issue. However, instead of stating that the VIP team needs to approve the change, we could link to documentation of some things to check or other helpful tips.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions