Skip to content

Move WPCS Deprecated VIP Sniffs to VIPCS. #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaryJones merged 2 commits into from
Jan 3, 2019
Merged

Move WPCS Deprecated VIP Sniffs to VIPCS. #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b235651
Move WPCS Deprecated VIP Sniffs to VIPCS
rebeccahum Dec 28, 2018
20f4838
Integration test: Refresh for removal of sniffs
rebeccahum Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions WordPress-VIP-Go/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@


<!-- Things that probably won't work and needs a dev to review -->
<rule ref="WordPress.VIP.FileSystemWritesDisallow.file_ops_fwrite">
<rule ref="WordPressVIPMinimum.VIP.FileSystemWritesDisallow.file_ops_fwrite">
<type>error</type>
<severity>6</severity>
<message>File system writes only work in /tmp/ and inside the /uploads/ folder on VIP Go. To do filesystem writes you must use the WP_Filesystem class, using functions such as %s() won't work or will return unexpected results. Read more here: https://vip.wordpress.com/documentation/using-wp_filesystem-instead-of-direct-file-access-functions/</message>
Expand All @@ -22,12 +22,12 @@
<severity>6</severity>
<message>Due to server-side caching, server-side based client related logic might not work. We recommend implementing client side logic in JavaScript instead.</message>
</rule>
<rule ref="WordPress.VIP.RestrictedVariables.cache_constraints___COOKIE">
<rule ref="WordPressVIPMinimum.VIP.RestrictedVariables.cache_constraints___COOKIE">
<type>error</type>
<severity>6</severity>
<message>Due to server-side caching, server-side based client related logic might not work. We recommend implementing client side logic in JavaScript instead.</message>
</rule>
<rule ref="WordPress.VIP.RestrictedVariables.cache_constraints___SERVER__HTTP_USER_AGENT__">
<rule ref="WordPressVIPMinimum.VIP.RestrictedVariables.cache_constraints___SERVER__HTTP_USER_AGENT__">
<type>error</type>
<severity>6</severity>
<message>Due to server-side caching, server-side based client related logic might not work. We recommend implementing client side logic in JavaScript instead.</message>
Expand Down Expand Up @@ -135,11 +135,6 @@
<type>warning</type>
<severity>10</severity>
</rule>
<rule ref="WordPress.VIP.SuperGlobalInputUsage.AccessDetected">
<!-- Needs a manual check -->
<severity>7</severity>
<type>warning</type>
</rule>
<rule ref="WordPress.Security.NonceVerification.NoNonceVerification">
<!-- Needs a manual check -->
<type>warning</type>
Expand Down Expand Up @@ -237,10 +232,10 @@
<!-- We trust that translations are safe on VIP Go -->
<severity>1</severity>
</rule>
<rule ref="WordPress.VIP.AdminBarRemoval.RemovalDetected">
<rule ref="WordPressVIPMinimum.VIP.AdminBarRemoval.RemovalDetected">
<severity>3</severity>
</rule>
<rule ref="WordPress.VIP.AdminBarRemoval.HidingDetected">
<rule ref="WordPressVIPMinimum.VIP.AdminBarRemoval.HidingDetected">
<severity>3</severity>
</rule>
<rule ref="WordPressVIPMinimum.VIP.ProperEscapingFunction.htmlAttrNotByEscHTML">
Expand Down Expand Up @@ -320,7 +315,7 @@


<!-- Silence is golden, these don't affect us on VIP Go -->
<rule ref="WordPress.VIP.RestrictedVariables.user_meta__wpdb__usermeta">
<rule ref="WordPressVIPMinimum.VIP.RestrictedVariables.user_meta__wpdb__usermeta">
<severity>0</severity>
</rule>

Expand Down
Loading