Skip to content

RestrictedFunctions: Add stats_get_csv() #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebeccahum merged 2 commits into from
Feb 6, 2020
Merged

RestrictedFunctions: Add stats_get_csv() #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15a1cd9
RestrictedFunctions: Add stats_get_csv() along with unit tests
rebeccahum Jan 31, 2020
78fc9ba
Merge branch 'develop' into fix_461
rebeccahum Feb 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,13 @@ public function getGroups() {
'delete_site_option',
],
],
'stats_get_csv' => [
'type' => 'error',
'message' => 'Using `%s` outside of Jetpack context pollutes the stats_cache entry in the wp_options table. We recommend building a custom function instead.',
'functions' => [
'stats_get_csv',
]
],
'wp_mail' => [
'type' => 'warning',
'message' => '`%s` should be used sparingly. For any bulk emailing should be handled by a 3rd party service, in order to prevent domain or IP addresses being flagged as spam.',
Expand Down
3 changes: 3 additions & 0 deletions WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,3 +224,6 @@ delete_option( $bar ); // Ok.

wpcom_vip_get_page_by_path(); // Ok - VIP recommended version of get_page_by_path().
get_page_by_path( $page_path ); // Warning.

$popular = stats_get_csv( 'postviews', [ 'days' => 2, 'limit' => 20 ] ); // Error.
$popular = custom_stats_get_csv( 'postviews', [ 'days' => 2, 'limit' => 20 ] ); // Ok.
Copy link
Contributor

@GaryJones GaryJones Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a clear linespace at the end of the file.

1 change: 1 addition & 0 deletions WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ public function getErrorList() {
218 => 1,
220 => 1,
222 => 1,
228 => 1,
];
}

Expand Down