Skip to content

Travis: Use PHPUnit 7 with PHP 8#490

Merged
GaryJones merged 1 commit intodevelopfrom
fix/travis-php-8
Jul 6, 2020
Merged

Travis: Use PHPUnit 7 with PHP 8#490
GaryJones merged 1 commit intodevelopfrom
fix/travis-php-8

Conversation

@GaryJones
Copy link
Contributor

By default, our tests on PHP 8 nightly use PHPUnit 5.2.7, which includes calls to each(), which was removed in PHP 8, and therefore fails.

By ignoring the platform requirements, then PHPUnit 7 should be installed, as that's the highest version supported in the composer.json constraints.

All credit to @jrfnl for the same work she did on WPCS.

By default, tests on PHP 8 use PHPUnit 5.2.7, which includes calls to `each()`, which was removed in PHP 8, and therefore fails.

By ignoring the platform requirements, then PHPUnit 7 should be installed.
@GaryJones GaryJones added this to the 2.1.0 milestone Jul 6, 2020
@GaryJones GaryJones requested a review from rebeccahum July 6, 2020 12:36
@GaryJones GaryJones self-assigned this Jul 6, 2020
@GaryJones GaryJones merged commit d4a4e1c into develop Jul 6, 2020
@GaryJones GaryJones deleted the fix/travis-php-8 branch July 6, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant