Skip to content

Variables/RestrictedVariables: fix namespace of unit test file + fix test #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaryJones merged 2 commits into from
Jul 27, 2020
Merged

Variables/RestrictedVariables: fix namespace of unit test file + fix test #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e03066
Variables/RestrictedVariables: fix namespace of unit test file
jrfnl Jul 27, 2020
bc780bb
Variables/RestrictedVariables: fix the test
jrfnl Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions WordPressVIPMinimum/Tests/Variables/RestrictedVariablesUnitTest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ $phrase = <<<EOD
Your user-agent is {$_SERVER['HTTP_USER_AGENT']}
EOD;

// phpcs:set WordPressVIPMinimum.Variables.RestrictedVariables exclude user_meta
$query = "SELECT * FROM $wpdb->usermeta"; // Error.
// phpcs:set WordPressVIPMinimum.Variables.RestrictedVariables exclude[] user_meta
$query = "SELECT * FROM $wpdb->usermeta"; // Ok, excluded.

// phpcs:set WordPressVIPMinimum.Functions.RestrictedFunctions exclude false
// phpcs:set WordPressVIPMinimum.Functions.RestrictedFunctions exclude[]

foo( $_SESSION ); // Error.
foo( $_SESSION['bar'] ); // Error.
2 changes: 1 addition & 1 deletion WordPressVIPMinimum/Tests/Variables/RestrictedVariablesUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @package VIPCS\WordPressVIPMinimum
*/

namespace WordPress\Tests\Variables;
namespace WordPressVIPMinimum\Tests\Variables;

use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;

Expand Down