Conversation
GaryJones
force-pushed
the
changelog/2.2.0
branch
from
db97665 to
c885ff2
Compare
rebeccahum
previously approved these changes
Aug 31, 2020
GaryJones
force-pushed
the
changelog/2.2.0
branch
from
c885ff2 to
ed07746
Compare
jrfnl
previously requested changes
Sep 7, 2020
Collaborator
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Generally looking good.
Aside from the inline notes, two additional remarks:
- An entry is missing for PR #561 / issue #469.
- Most entries seem to use the PR title. While this may be clear for people reasonably deeply into the sniffs, I wonder if some can be made more descriptive to allow end-users to understand the change better.
May not be needed if this changelog is mainly intended for internal use, not for the customers.
GaryJones
force-pushed
the
changelog/2.2.0
branch
from
ed07746 to
82e98f3
Compare
GaryJones
force-pushed
the
changelog/2.2.0
branch
from
82e98f3 to
0bb1580
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ Reviews & approval welcome. I'll merge this myself (if approved) just before the release. ❗
Includes all currently merged changes.
Since we now have an external contributor (Juliette), then we can/should start giving props.
I also find it useful when other change logs give a link to the PR where I can start following the trail of what exactly the change was and why it was made, so I've added them in as well. By using full inline markdown link (rather than just
[#123]inline and the[#123]: https://…at the bottom), then it makes the copy-paste into the Release notes cleaner.