Skip to content

Functions/DynamicCalls: Remove the word "blacklisted" and use "disallowed" #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebeccahum merged 1 commit into from
Nov 23, 2020
Merged

Functions/DynamicCalls: Remove the word "blacklisted" and use "disallowed" #596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions WordPressVIPMinimum/Sniffs/Functions/DynamicCallsSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class DynamicCallsSniff extends Sniff {
*
* @var array
*/
private $function_names = [
private $disallowed_functions = [
'assert' => true,
'compact' => true,
'extract' => true,
Expand Down Expand Up @@ -141,7 +141,7 @@ private function collect_variables() {
*/
$current_var_value = $this->strip_quotes( $this->tokens[ $value_ptr ]['content'] );

if ( isset( $this->function_names[ $current_var_value ] ) === false ) {
if ( isset( $this->disallowed_functions[ $current_var_value ] ) === false ) {
// Text string is not one of the ones we're looking for.
return;
}
Expand All @@ -167,7 +167,7 @@ private function find_dynamic_calls() {

/*
* If variable is not found in our registry of variables, do nothing, as we cannot be
* sure that the function being called is one of the blacklisted ones.
* sure that the function being called is one of the disallowed ones.
*/
if ( ! isset( $this->variables_arr[ $this->tokens[ $this->stackPtr ]['content'] ] ) ) {
return;
Expand Down