Skip to content

WordPress.Security.NonceVerification.NoNonceVerification: Remove outdated reference from WordPress-VIP-Go ruleset and let inheritance from parent #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebeccahum merged 2 commits into from
Jan 13, 2021
Merged

WordPress.Security.NonceVerification.NoNonceVerification: Remove outdated reference from WordPress-VIP-Go ruleset and let inheritance from parent #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2debb7
WordPress.Security.NonceVerification.NoNonceVerification: Remove outd…
rebeccahum Jan 8, 2021
77e07fe
Change reference in test to parent sniff
rebeccahum Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPress-VIP-Go/ruleset-test.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ $external_resource = file_get_contents( $test ); // Warning + Message.
$file_content = file_get_contents( 'my-file.svg' ); // Ok.
wpcom_vip_file_get_contents( $bar ); // Ok.

// WordPress.Security.NonceVerification.NoNonceVerification
// WordPress.Security.NonceVerification (inherited from parent)
function bar_foo() {
if ( ! isset( $_POST['test'] ) ) { // Error.
return;
Expand Down
5 changes: 0 additions & 5 deletions WordPress-VIP-Go/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,6 @@


<!-- Warnings and other things -->
<rule ref="WordPress.Security.NonceVerification.NoNonceVerification">
<!-- Needs a manual check -->
<type>warning</type>
<severity>10</severity>
</rule>
<rule ref="WordPress.Security.ValidatedSanitizedInput.InputNotSanitized">
<!-- Needs a manual check -->
<type>warning</type>
Expand Down