WordPress-VIP-Go: Replace WordPress.WP.GlobalVariablesOverride.OverrideProhibited with WordPress.WP.GlobalVariablesOverride.Prohibited

[rebeccahum]

Fixes #609.

[GaryJones]

Since it's been so long since this change happened, and we didn't notice, do we need an addition to a ruleset test to cover this as well?

[rebeccahum]

It does look like we already do in the parent ruleset:

VIP-Coding-Standards/WordPressVIPMinimum/ruleset-test.inc

Lines 72 to 74 in 6d3f526

	// WordPress.WP.GlobalVariablesOverride
	$GLOBALS['wpdb'] = 'test'; // Error.

I'm not sure what difference it would make for violation name changes that occur if it still triggers an expected error regardless...would it be a different type of test with an ignore statement?

[jrfnl]

Reviewed after the fact.

To be quite fair, I'd recommend for this severity change to be removed completely. In reality it hasn't been active since the update to WPCS 2.0.0+ in April 2019 in commit 53505ff and AFAICS nobody has complained about it.

The reason why you probably haven't received many complaints is that the sniff has had quite a lot of improvements over the years which reduced false positives.

The only false positives which are common with this sniff is when using "views" which are themselves in stand-alone files (global namespace), but are in reality only used via an include from within a function. The variables declared in those views will, in practice, be local to the function doing the include, but that is something the sniff cannot analyse.
To exclude those, a property can be enabled. See: https://github.com/WordPress/WordPress-Coding-Standards/wiki/Customizable-sniff-properties#global-wp-variable-override-check-in-the-global-namespace

More than anything, the sniff currently has a lot of false negatives as there are a lot of global variables in WP which the sniff is not yet looking for.