WordPress-VIP-Go: Add ignore statement for ruleset since VariableAnalysis.CodeAnalysis.VariableAnalysis #636
Closed
rebeccahum wants to merge 1 commit intodevelopfrom
Closed
WordPress-VIP-Go: Add ignore statement for ruleset since VariableAnalysis.CodeAnalysis.VariableAnalysis #636rebeccahum wants to merge 1 commit intodevelopfrom
rebeccahum wants to merge 1 commit intodevelopfrom
Conversation
…ysis.CodeAnalysis.VariableAnalysis was being triggered
Contributor
Author
|
Nevermind, going to stick this in #635 since related. |
Collaborator
|
My comment is superseded by the issue being closed while I was writing it. Posting it anyway in case this comes up again. With the current I might be misunderstanding, so could you please elaborate on what this is supposed to be solving ? Other notes:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the
global $wpdbin #635 triggered a warning on line 300.